mapbox / maki

A POI Icon Set
http://labs.mapbox.com/maki-icons/
Creative Commons Zero v1.0 Universal
1.5k stars 213 forks source link

`racetrack-cycling` #551

Closed tristen closed 3 years ago

tristen commented 3 years ago

Description of change

Adds racetrack-cycling which is supported under maki_beta values in Streets v8

Link to demonstration

https://api.mapbox.com/styles/v1/tristen/ckpio9qjr37sr18pqxmldy0zr.html?fresh=true&title=view&access_token=pk.eyJ1IjoidHJpc3RlbiIsImEiOiJjajZoOXU4Z2kwNnppMnlxd2d6bTFvZ2xtIn0.PP7AoUakMfeqdXFHdsY0oA


Ref #471

For author

For reviewer

tristen commented 3 years ago

Is it intentional that the wheels are different pixel widths?

It's intentional! It's supposed to mimic the rear wheel often looking different on track bikes

That said, that isn't always the case and for less visual guesswork it might be simpler to make them both stroke width.

I see a few spots where this doesn't fully align to the half or full pixel grid. Does it work to shift the shoulder and arm up?

👍 Will tweak this.

tristen commented 3 years ago

👋 @ClareTrainor back to you. I decided to make the back wheel filled in as it felt like it needed a higher degree of separation from bicycle-share

tristen commented 3 years ago

Ah! thanks for the catch @ClareTrainor I think I minified a bit too aggressively from https://jakearchibald.github.io/svgomg/. It should work as expected from Illustrator now:

Screen Shot 2021-06-16 at 10 17 13 AM