Historic - Githubissues

mapbox / maki

A POI Icon Set

http://labs.mapbox.com/maki-icons/

Creative Commons Zero v1.0 Universal

1.5k stars 213 forks source link

Historic #561

Closed tristen closed 2 years ago

tristen commented 2 years ago

We don't have an icon to represent historical sites so a response like this is not surprising when a default marker is shown for a plaque that says:

Hostage taking January 9, 2015

OSM Tag https://taginfo.openstreetmap.org/keys/historic
Icon suggestion Historic sites are often represented in the real world with a sign

Udobnyj commented 2 years ago

I apologize for delaying the task. I wanted to do it last week. So, I'm still just trying to fit in the actual Maki style. So quickly sketched out some options, three seem to be the best. My fav is the third option.

1.1.png

2.1.png

3.1.png

tristen commented 2 years ago

@Udobnyj Agree! 3 looks strong

Udobnyj commented 2 years ago

Awesome ❤️ Sorry, but can I ask for some help. What do I need to do next? There are some rules for adding a Maki icon to set, I need to name it, clear SVG or ask somebody to add it to the system or something else? Sorrryyyy 😓

tristen commented 2 years ago

There are some rules for adding a Maki icon to set, I need to name it, clear SVG or ask somebody to add it to the system or something else?

Looking at an older PR (like this) is a good reference of what needs to happen next. There's also a template here that can help with formatting!

Udobnyj commented 2 years ago

@tristen Thank you so much!