search

mapbox / maki

A POI Icon Set
http://labs.mapbox.com/maki-icons/
Creative Commons Zero v1.0 Universal
1.5k stars 213 forks source link

Historic icon #562

Closed Udobnyj closed 2 years ago

Udobnyj commented 2 years ago

Adding a Historic icon. Closes https://github.com/mapbox/maki/issues/561

historic

Udobnyj commented 2 years ago

@tristen Hey! Thank you for your comments!

First, about unnecessary anchors, remember I had an issue with lines, and I dealt with it only exported icon without flattening it. Screen Shot 2022-03-22 at 17 35 15

These anchors were created automatically. I tried to delete them, but lines issue came back 😓

Second, about coordinates. I tried the 1px option, but it looks too thin to me. Here is how it looks on the maps: options

And I added it to the studio. 1px leg historic sign 1.5px leg historic sign

Still feels like 1,5px leg working better. But maybe there is no different? What do you think?

Anyway, if we decide to be so strictly grid-bound, I have a question. I looked at our actual icons, and I will say that they often deviate from our guides, both in line thickness and dot placement. Few examples: Screen Shot 2022-03-22 at 16 31 48

Maybe I should then take over the task and fix it all?

Udobnyj commented 2 years ago

We discussed with @tristen and decided to make a thin leg. All unnecessary anchors were removed, an icon was rechecked.

Screen Shot 2022-03-23 at 10 59 26