mapbox / maki

A POI Icon Set
http://labs.mapbox.com/maki-icons/
Creative Commons Zero v1.0 Universal
1.5k stars 213 forks source link

Centering 38 maki icons #565

Closed Udobnyj closed 2 years ago

Udobnyj commented 2 years ago

Based on this task, I adjusted 46 of our icons to work better with the background.

I didn't change the vector. I just moved them inside the artboards. But six of them are not along the pixel grid but 0.5px: shelter, bowling-alley, basketball, ferry-JP, amusement-park, and religious-muslim.

MAIN STUDIO TEST LINK

Concreete 0.5px icons links I didn't find shelter, bowling-alley, and ferry-JP, so I replaced the other icons.

shelter

bowling-alley

ferry-JP

basketball

amusement-park

religious-muslim

Udobnyj commented 2 years ago

I was thinking about 0.5px moved icons. I think I have an idea of how to fix it. I can do it in this task. Along with sizing, I can adjust them to fit the pixel grid

tristen commented 2 years ago

@Udobnyj this is a little tedious, but could you share a map example with these icons using a background? Also perhaps a map example showing the before with backgrounds? Just to get a better sense of how centering these addresses visual inconsistency?

tristen commented 2 years ago

But six of them are not along the pixel grid but 0.5px: shelter, bowling-alley, basketball, ferry-JP, amusement-park, and religious-muslim.

Hmm @Udobnyj we should avoid offsetting these to 0.5px just for centering and consider redrawing these instead.

Edit Oh! I missed your comment here https://github.com/mapbox/maki/pull/565#issuecomment-1140839220

Screen Shot 2022-05-30 at 10 46 51 AM
Udobnyj commented 2 years ago

I decided to revert ten icons (6 of those that I moved by 0.5 pixels and four more). As I wrote above, I will correct them in this resizing task. Therefore, this push now has 38 changed icons (I forgot about charging-station.svg and added it).

Screen Shot 2022-05-30 at 19 48 18

LINK to the combining map

Below are links to specific ones. But it's too much of them to test it on the map. I think a better way will be to check others in my Figma file

May-30-2022 20-19-50

Shops

Screen Shot 2022-05-30 at 20 00 34

Fuel

Screen Shot 2022-05-30 at 19 58 45

Playground

Screen Shot 2022-05-30 at 19 57 29

Restaurant-pizza

Screen Shot 2022-05-30 at 19 59 37

Mountain

Screen Shot 2022-05-30 at 20 04 32