Closed Udobnyj closed 2 years ago
I was thinking about 0.5px moved icons. I think I have an idea of how to fix it. I can do it in this task. Along with sizing, I can adjust them to fit the pixel grid
@Udobnyj this is a little tedious, but could you share a map example with these icons using a background? Also perhaps a map example showing the before with backgrounds? Just to get a better sense of how centering these addresses visual inconsistency?
But six of them are not along the pixel grid but 0.5px: shelter, bowling-alley, basketball, ferry-JP, amusement-park, and religious-muslim.
Hmm @Udobnyj we should avoid offsetting these to 0.5px just for centering and consider redrawing these instead.
Edit Oh! I missed your comment here https://github.com/mapbox/maki/pull/565#issuecomment-1140839220
I decided to revert ten icons (6 of those that I moved by 0.5 pixels and four more). As I wrote above, I will correct them in this resizing task. Therefore, this push now has 38 changed icons (I forgot about charging-station.svg and added it).
Below are links to specific ones. But it's too much of them to test it on the map. I think a better way will be to check others in my Figma file
Based on this task, I adjusted 46 of our icons to work better with the background.
I didn't change the vector. I just moved them inside the artboards. But six of them are not along the pixel grid but 0.5px: shelter, bowling-alley, basketball, ferry-JP, amusement-park, and religious-muslim.
MAIN STUDIO TEST LINK
Concreete 0.5px icons links I didn't find shelter, bowling-alley, and ferry-JP, so I replaced the other icons.
shelter
bowling-alley
ferry-JP
basketball
amusement-park
religious-muslim