Adding nightclub icon - Githubissues

Udobnyj commented 5 months ago

Helping @aokj4ck with "Update Maki icons in repo" task

I don't like the old ball metaphor, so I think something like "dance" fits better

So here is the icon nightclub

Plus bigger

Here's the style link (though I'm not sure if we really need this one on the map since it's only used in our mapbox-search-ios SDK). But I decided to test it out in the POI shape with the others, just to see.

tristen commented 5 months ago

@Udobnyj the legibility here is hard to make out.

The stars are proportionally similar to the head which makes them hard to distinguish.
The left arm is too close to the body making it slightly hard to distinguish a body

Also, I wonder if this icon should conform merely closely to existing person in motion Maki icons:

Equal sized head
Angular lines that follow the pixel grid

Udobnyj commented 5 months ago

Hey @tristen , Thanks a lot for your feedback!

I totally agree with you about the legibility issues and your points on the stars and hands. I'll brainstorm some solutions for those tomorrow.

Regarding the Maki icons, I've got a few thoughts. I'm currently updating them on an optional basis and, after analyzing them, I've noticed that our people icons aren't as consistent as they might appear. Take the head size, for example;

Also, the pixel align and rounded corners vary across the icons.

As I'm working on a new approach for Maki, I'm aiming for a smoother and more uniform style. So, I thought it would be best to design the new icon in this style as part of a gradual update.

I see your point, though. Perhaps I need to tone down my icon a bit to prevent it from standing out too much for now.

Plus, I wanted to revisit a question we discussed about a year ago: Do we still need to adhere to the pixel-align rule? With screen resolutions these days, pixel visibility isn't really an issue anymore. 😓

tristen commented 5 months ago

@Udobnyj I like the new approach you are taking to the icons! Excited to see this develop

Do we still need to adhere to the pixel-align rule?

I still think pixel alignment is important. Maki icons are rendered at 15px x 15px as PNGs. Pixel alignment helps to prevent poor results from anti-aliasing. But there's totally room to deviate from this (many of the icons do). As long as things look legible at 100% screen resolution under different scenarios (white/black against POI background colors) we're good 👍

Udobnyj commented 4 months ago

Hey guys @tristen @aokj4ck , I got a bit swamped with some other tasks that were more pressing, but I'm back now. I've sketched out three quick concepts for the icon and would love to hear your thoughts.