search

mapbox / mapbox-base-android

This repository hosts annotation processors and module providers for Mapbox modular SDKs.
Other
11 stars 8 forks source link

Add Logger module #21

Closed Lebedinsky closed 4 years ago

Lebedinsky commented 4 years ago

This PR is about moving Logger from navigation SDK to base-android repo as part of this task

Lebedinsky commented 4 years ago

@LukasPaczos ptal, and let me know if you'll have comments\another vision on it. Cause I doubt about MapboxNavigationModuleType#Logger and where Logger class should be placed (in navigation project it placed separately from implementation).

LukasPaczos commented 4 years ago

We'll also need to initialize the Bintray repository.

Lebedinsky commented 4 years ago

Stopped for now due to other priorities

LukasPaczos commented 4 years ago

The Bintray repo is available in https://bintray.com/mapbox/mapbox/com.mapbox.common%3Alogger. @Lebedinsky whenever you have comments fixed, we can pair and push the version to be able to request the artifactory snapshot repo.

LukasPaczos commented 4 years ago

Thanks for pushing the artifacts @Lebedinsky. I've requested JCenter and Artifactory access, but currently, it's throwing:

Failed to send a message: Empty packages are not allowed in JCenter.

but obviously the package isn't empty. I'm going to give it a shot tomorrow morning again.

LukasPaczos commented 4 years ago

Still running into the same issue. I do not want to release the package just to request JCenter and Artifactory access, so I wrote a support ticket.

LukasPaczos commented 4 years ago

I just rebased the PR and tried requesting JCenter access again and failed with this message again:

Failed to send a message: Empty packages are not allowed in JCenter.

Are we good to merge besides that @Lebedinsky? If yes, let's do that and release it to Bintray only. When the package will have a version published, maybe then it'll allow me to request JCenter and Artifactory access.

LukasPaczos commented 4 years ago

After releasing the v0.0.1-alpha.3, there were no more issues with the request for JCenter and Artifactory access :tada:

From now on, the snapshots are being hosted at http://oss.jfrog.org/oss-snapshot-local/com/mapbox/common/logger/.