search

mapbox / mapbox-base-android

This repository hosts annotation processors and module providers for Mapbox modular SDKs.
Other
11 stars 8 forks source link

Keep MapboxLogger rule for minification #41

Closed Guardiola31337 closed 4 years ago

Guardiola31337 commented 4 years ago

After https://github.com/mapbox/mapbox-navigation-android/pull/2774 examples app is crashing if Proguard is enabled because of MapboxLogger.

Adding -keep class com.mapbox.common.logger.MapboxLogger {*;} in the Navigation SDK Proguard rules fixes it but I believe we should add the @Keep annotation / custom Proguard rules in com.mapbox.common:logger so it's handled automatically and clients don't need to worry about.

cc @RingerJK @LukasPaczos