search

mapbox / mapbox-directions.js

Leaflet plugin for the Mapbox Directions API
https://www.mapbox.com/mapbox.js/example/v1.0.0/mapbox-directions/
ISC License
60 stars 23 forks source link

Configurable instructions language #94

Closed doflip closed 7 years ago

doflip commented 8 years ago

Usage example: L.mapbox.directions({language: 'pt'});

The default remains english language.

freenerd commented 8 years ago

@doflip thanks for the PR

@tmcw how do you feel about this? do you think instead of search/replacing the individual values, we could already here get https://www.transifex.com/ to work? this would down the line make it easier to migrate the changes from mapbox-directions.js to the mapbox directions API (where this eventually should live). Since @doflip likely doesn't want to wait until we get our shit together on the API I'm happy to have this in mapbox-directions.js for a while ...

tmcw commented 8 years ago

I think we should land this in the directions API first, rather than it hanging out in the mapbox-directions.js codebase intermediately. Free to use this PR as a fork in the meantime, but we should expedite doing this the right way, on the server side.

tmcw commented 7 years ago

Closing this PR, but keeping the branch alive if someone wants to start from it to do client-side translations for the time being: the server-side approach is the plan.