search

mapbox / mapbox-gl-accessibility

An accessibility control for Mapbox GL JS
https://labs.mapbox.com/mapbox-gl-accessibility
ISC License
68 stars 21 forks source link

support Polygons and LineStrings via their bbox #13

Closed andrewharvey closed 6 years ago

andrewharvey commented 6 years ago

This doesn't merge features across tile boundaries, so you can end up with multiple accessible elements for each feature.

I considered using a feature id if exists to give strictly 1 accessible element per feature, but it might make sense to see if this get's addressed in GL JS https://github.com/mapbox/mapbox-gl-js/issues/6019

tristen commented 6 years ago

Sweet!

Can the changes added to example.index.js be split into its own example instead? Demonstrating adding a custom source and applying accessibility to it.

andrewharvey commented 6 years ago

Can the changes added to example.index.js be split into its own example instead? Demonstrating adding a custom source and applying accessibility to it.

Sure. I think at some point it makes sense to move the examples into mapbox-gl-js as it ensures they are more easily discoverable and we leverage all the existing infrastructure, re hosting, easy viewing online, auto access token.