Closed allthesignals closed 4 years ago
👋 Thanks for the PR @allthesignals. Instead of throwing the methods in the constructor I wonder if its cleaner to omit those arrow functions entirely and bind them to this
in the constructor i.e
this.queryFeatures = this.queryFeatures.bind(this)
What do you think?
👋 Thanks for the PR @allthesignals. Instead of throwing the methods in the constructor I wonder if its cleaner to omit those arrow functions entirely and bind them to
this
in the constructor i.ethis.queryFeatures = this.queryFeatures.bind(this)
What do you think?
@tristen Yep! That will make for a smaller diff, too.
I'll update. Thanks for the feedback :)
I was having trouble getting this to build because babel did not like the syntax of the class property arrow functions. Other ES features work.
Instead I just moved these array function methods into to the constructor until we can understand why this babel feature isn’t working. This is what would happen if babel transpilation worked.
This is a workaround to get the thing to build. This change helps:
One possible step forward towards closing #17