search

mapbox / mapbox-gl-geocoder

Geocoder control for mapbox-gl-js using Mapbox Geocoding API
https://mapbox.com/mapbox-gl-js/example/mapbox-gl-geocoder/
ISC License
368 stars 180 forks source link

Empty published dist/mapbox-gl-geocoder.min.js #384

Closed elygeo closed 4 years ago

elygeo commented 4 years ago

Hi, For the v4.6 the minified JS file on NPM is empty.

https://unpkg.com/@mapbox/mapbox-gl-geocoder@4.6.0/dist/mapbox-gl-geocoder.min.js

andrewharvey commented 4 years ago

@tristen maybe this means the npm run prepublish step at https://github.com/mapbox/mapbox-gl-geocoder/blob/master/CONTRIBUTING.md#deploying might not have been run before the npm publish?

Also looks like https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-geocoder/v4.6.0/mapbox-gl-geocoder.min.js wasn't deployed.

3zzy commented 4 years ago

@andrewharvey Sorry, is something being done about this?

andrewharvey commented 4 years ago

@3zzy not much I can do since I don't have permissions to publish to NPM or the CDN.

tristen commented 4 years ago

🙈 sorry folks. I'll get a patched version together to address this now.

tristen commented 4 years ago

👋 Published 4.7.0 to npm with the dist directory (https://unpkg.com/@mapbox/mapbox-gl-geocoder@4.7.0/dist/mapbox-gl-geocoder.min.js)