Fix codescan bugs - Githubissues

mapbox / mapbox-gl-geocoder

Geocoder control for mapbox-gl-js using Mapbox Geocoding API

https://mapbox.com/mapbox-gl-js/example/mapbox-gl-geocoder/

ISC License

368 stars 180 forks source link

Fix codescan bugs #457

Closed mpothier closed 2 years ago

mpothier commented 2 years ago

Minor fixes to string matching, regular expressions for code scanning compliance.

[X] briefly describe the changes in this PR
[ ] write tests for all new functionality
[ ] run npm run docs and commit changes to API.md
[ ] update CHANGELOG.md with changes under master heading before merging

mpothier commented 2 years ago

@mpothier two things - one of them is just the question i asked on the code about the regex. The other is, is there an easy way to unit test this regex? I suppose the previous one is not unit tested. Do you think that'd be worth adding?

Yes, good call on that - I'll add unit tests for the regex.