I noticed that the geolocation feature (added in #444) adds a marker to the map and flies the map to the new location, even if the marker and flyTo options are set to false. This PR changes that behavior to be consistent with query(). I also performed some minor cleanup on some of the related tests, and removed some hanging whitespace.
I considered further DRYing those option checks and moving them into _handleMarker() and _fly(), but decided to keep that a concern of the caller, rather than those functions themselves. I don't feel strongly about it either way, though.
[x] briefly describe the changes in this PR
[x] write tests for all new functionality
[x] update CHANGELOG.md with changes under master heading before merging
I noticed that the geolocation feature (added in #444) adds a marker to the map and flies the map to the new location, even if the
marker
andflyTo
options are set tofalse
. This PR changes that behavior to be consistent withquery()
. I also performed some minor cleanup on some of the related tests, and removed some hanging whitespace.I considered further DRYing those option checks and moving them into
_handleMarker()
and_fly()
, but decided to keep that a concern of the caller, rather than those functions themselves. I don't feel strongly about it either way, though.master
heading before merging