mapbox / mapbox-gl-geocoder

Geocoder control for mapbox-gl-js using Mapbox Geocoding API
https://mapbox.com/mapbox-gl-js/example/mapbox-gl-geocoder/
ISC License
362 stars 181 forks source link

Import with JSDeliver broken #524

Open ajdubovoy opened 7 months ago

ajdubovoy commented 7 months ago

Hi, this code:

import * as mapboxmapboxGlGeocoder from 'https://esm.run/@mapbox/mapbox-gl-geocoder';

console.log(mapboxmapboxGlGeocoder)

will raise the following error:

Uncaught TypeError: Cannot read properties of null (reading 'nanoid')
    at events.js:2:32

So, the package is not importable at all. As far as I can tell, the issue seems to be that if i go to https://cdn.jsdelivr.net/npm/nanoid@3.3.7/+esm, it gives no default export (export default null), whereas the Mapbox package is set to import s from"/npm/nanoid@3.3.7/+esm" and then does s.nanoid and that's null. So, I believe the solution would be instead to:

import { nanoid } from"/npm/nanoid@3.3.7/+esm"

and to rely on the specific export rather than the default export.

Thanks so much!