add stubs for instrumentile-gl

mapbox / mapbox-gl-js-mock

A maybe-some-day-fully-featured mock for mapbox-gl-js

BSD 3-Clause "New" or "Revised" License

25 stars 33 forks source link

add stubs for instrumentile-gl #19

Closed sbma44 closed 6 years ago

sbma44 commented 6 years ago

@samanpwbb I've mocked out some additional functionality to enable unit testing of my new version of instrumentile. You generously offered to review when we discussed this in Slack -- mind having a look?

sbma44 commented 6 years ago

Hmm looks like there are some busted dependencies. I'll have to have a look at that tomorrow. Apologies for the false alarm!

sbma44 commented 6 years ago

ok, tests are passing, though to resolve the dependency issues I had to make some relatively strident decisions about moving to a newer GL JS. I think this is all fine but it probably calls for a major version bump given the likelihood of previous integrations being unhappy with the changed environment in which this project exists.