search

mapbox / mapbox-gl-js

Interactive, thoroughly customizable maps in the browser, powered by vector tiles and WebGL
https://docs.mapbox.com/mapbox-gl-js/
Other
11.18k stars 2.22k forks source link

Remove `miter-limit` and `round-limit`? #4092

Open lucaswoj opened 7 years ago

lucaswoj commented 7 years ago

From @nickidlugash on June 10, 2015 17:36

Per random conversation with @ansis and @kkaefer: should we remove these two properties for v8? Has anyone actually ever used them? In theory these are useful, but in practice, the default values work well enough that I've never, ever changed them.

@samanpwbb @peterqliu @andreasviglakis have you ever come across joints in geometries that are extreme enough to want to adjust these properties?

/cc @mayagao

Copied from original issue: mapbox/mapbox-gl-style-spec#286

lucaswoj commented 7 years ago

From @peterqliu on June 10, 2015 19:21

I haven't changed them, either, but since they're already implemented and there may be future use cases, I'm leaning toward keeping them in.

lucaswoj commented 7 years ago

From @ansis on June 10, 2015 20:9

I'm in favour of removing them.

round-limit isn't a concept that exists elsewhere and there shouldn't be a case where a user needs to change it. We should definitely remove this.

miter-limit already has a hardcoded maximum value because our implementation can't support really long miters. The bevel line join type is what a low miter-limit would look like. I think the difference between what you could do with and without it is tiny, so we should remove it.

lucaswoj commented 7 years ago

From @nickidlugash on June 10, 2015 21:16

round-limit isn't a concept that exists elsewhere

y, I've never seen/used this elsewhere.

I spent some time playing with this today, styling Streets landuse as lines (since those geometries have a lot of irregular edges) with line-widths of various thicknesses over about 5px. Although there are obvious visual differences with using different miter-limit values, I think the default (x2, which is fairly small), is good.

Given that in the last 9 months, no one has noticed that the bevel and miter join icons are currently switched in the app, I don't think anyone will miss miter-limit.

If we want to leave it in though, we could make this property less prominent in the app. Right now it takes up too much space. /cc @mayagao

lucaswoj commented 7 years ago

From @samanpwbb on June 11, 2015 22:14

+1 for removing these!

lucaswoj commented 7 years ago

From @nickidlugash on March 28, 2016 18:4

Anyone else have thoughts on this? Can we remove these for the next style spec version?