search

mapbox / mapbox-gl-js

Interactive, thoroughly customizable maps in the browser, powered by vector tiles and WebGL
https://docs.mapbox.com/mapbox-gl-js/
Other
11.23k stars 2.23k forks source link

npm install breaks tests #6774

Open ryanhamley opened 6 years ago

ryanhamley commented 6 years ago

mapbox-gl-js version: 0.45.0

Steps to Trigger Behavior

  1. npm install
  2. yarn test

Expected Behavior

npm install and yarn install will produce the same output so that all tests will pass correctly

Actual Behavior

npm install bypasses the yarn.lock file and installs a newer version of @mapbox/batfish that breaks some tests.

Possible solution

set up npm install to fallback to yarn with the use-yarn node module

andrewharvey commented 5 years ago

With the latest master and batfish version, the tests pass even when using npm install. That said, I think use-yarn is a good idea to prevent this issue popping up in the future.

asheemmamoowala commented 5 years ago

@ryanhamley The contributing docs only every mention using yarn with this project. Is there a use-case or reason fro needing to support npm?

ryanhamley commented 5 years ago

Just that it's very common for people to use npm install then wonder why things aren't working