Fallback images are not working with manually added image - Githubissues

mapbox / mapbox-gl-js

Interactive, thoroughly customizable maps in the browser, powered by vector tiles and WebGL

https://docs.mapbox.com/mapbox-gl-js/

Other

11.21k stars 2.22k forks source link

Fallback images are not working with manually added image #9900

Closed francois2metz closed 4 years ago

francois2metz commented 4 years ago

mapbox-gl-js version: 1.11.1

browser: Firefox, Chrome and I believe all others

Steps to Trigger Behavior

Load and add an image with addImage named custom-marker
Load a geojson source (or any other source) with points
Style the points with an icon-image with a fallback

'icon-image': ["coalesce",
  ['image', 'nonexistant'],
  ['image', 'custom-marker']
]

Link to Demonstration

I updated the example "Draw GeoJSON points" to reproduce it https://docs.mapbox.com/mapbox-gl-js/example/geojson-markers/

https://jsfiddle.net/5ga36cnw/3/

Expected Behavior

The Mapbox DC office should display the custom marker

Actual Behavior

The Mapbox DC office don't display any marker

Additional stuff

If the loaded image is used in the first position, the marker image is displayed.

'icon-image': ["coalesce",
['image', 'custom-marker'],
['image', 'custom-marker']
]

I believe I fixed the bug in the PR https://github.com/mapbox/mapbox-gl-js/pull/9838

karimnaaji commented 4 years ago

This will be available in 1.12, thanks for the contribution @francois2metz !