mapbox / mapbox-gl-native-android

Interactive, thoroughly customizable maps in native Android powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
218 stars 114 forks source link

Location reuses feature object #702

Closed tobrun closed 3 years ago

tobrun commented 3 years ago

We have a raise condition on the location component feature. Currently we reuse the features object and pass that to gl-native. gl-native however parses this asynchronous and by that time we could already have updated it on the main thread. This currently results in a crash and is something we want to patch.

The feature object mentioned can be found in https://github.com/mapbox/mapbox-gl-native-android/blob/3467eefe5d5f66240107b123be4b7dd62564aed0/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/SymbolLocationLayerRenderer.java#L69

pengdev commented 3 years ago

Closed by https://github.com/mapbox/mapbox-gl-native-android/pull/703