search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.36k stars 1.33k forks source link

MGLStyleLayerDrawingContext.pitch is measured in radians #12944

Open 1ec5 opened 5 years ago

1ec5 commented 5 years ago

MGLStyleLayerDrawingContext.direction is measured in degrees, just like MGLMapView.direction and MGLMapCamera.heading, but MGLStyleLayerDrawingContext.pitch is measured in radians, which is inconsistent with MGLMapCamera.pitch. MGLStyleLayerDrawingContext.pitch should be measured in degrees for consistency with the other properties. This is especially important because MGLStyleLayerDrawingContext is (intentionally) undocumented. If client code needs radians, for example to work with SceneKit transforms, then it’s easy enough to convert using MGLRadiansFromDegrees().

/cc @fabian-guerra @jmkiley

stale[bot] commented 5 years ago

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.