mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.36k stars 1.33k forks source link

Fix macOS minimum deployment target #16412

Closed 1ec5 closed 4 years ago

1ec5 commented 4 years ago

MACOSX_DEPLOYMENT_TARGET is a CMake environment variable, so it isn’t possible for a CMake file to set the MACOSX_DEPLOYMENT_TARGET Xcode build setting directly. Instead, set the CMAKE_OSX_DEPLOYMENT_TARGET CMake variable, which ultimately sets the MACOSX_DEPLOYMENT_TARGET Xcode build setting.

Unlike in this Stack Overflow answer, I haven’t found it necessary to set it as a cached variable explicitly, so maybe that’s changed since 2015 or somehow works differently in the context of the mbgl build system.

Fixes #16396.

/cc @mapbox/gl-native @mapbox/maps-ios