[core][tile mode] Labels priority fixes

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL

https://mapbox.com/mobile

Other

4.36k stars 1.33k forks source link

[core][tile mode] Labels priority fixes #16432

Closed pozdnyakov closed 4 years ago

pozdnyakov commented 4 years ago

This PR fixes label priority issues in the Tile mode. It does the following:

strictly arranges all the intersecting labels accordingly to the style-defined priorities
fixes placement order of the variable labels. Before this change, all variable labels that could potentially intersect tile borders were placed first, breaking the style label placement priority order. Now, all the variable labels, which do not actually intersect the tile borders, are placed accordingly to the style-defined priorities

Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/338

pozdnyakov commented 4 years ago

Can we have a render test for it?

https://github.com/mapbox/mapbox-gl-js/pull/9638

chloekraw commented 4 years ago

Can we have a render test for it?

mapbox/mapbox-gl-js#9638

@pozdnyakov What about a render test only for the core changes outside of tile mode? I'm evaluating whether this change is significant enough to merit mention in the Maps SDK changelog.

pozdnyakov commented 4 years ago

@pozdnyakov What about a render test only for the core changes outside of tile mode? I'm evaluating whether this change is significant enough to merit mention in the Maps SDK changelog.

@chloekraw it does not change anything in Continuous/Static mode - no changes there, only a bit of refactoring..

chloekraw commented 4 years ago

Ah okay, thanks!