search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.36k stars 1.33k forks source link

mapbox-gl-native doesn't like GCC 10 #16438

Closed tsarajar closed 4 years ago

tsarajar commented 4 years ago

Platform: SLES 15 Mapbox SDK version: no idea, sorry

Steps to trigger behavior

We build mapbox-gl-native in Qt 5.15, and it isn't compatible with GCC 10. See https://bugreports.qt.io/browse/QTBUG-82850 with proposed fixes.

Expected behavior

Actual behavior

alexshalamov commented 4 years ago

@tsarajar fixed by https://github.com/mapbox/mapbox-gl-native/pull/16424. Closing for now, please reopen if needed. Thanks!

tmpsantos commented 4 years ago

@tsarajar fixed by #16424. Closing for now, please reopen if needed. Thanks!

Cherry-picked these changes to qt-staging.

krop commented 4 years ago

@tsarajar fixed by #16424. Closing for now, please reopen if needed. Thanks!

Cherry-picked these changes to qt-staging.

16424 doesn't have the include fix in render_vector_source.cpp. See https://bugzilla.opensuse.org/show_bug.cgi?id=1158510#c25 for the background

tmpsantos commented 4 years ago

@krop added, thanks for the heads-up!

tsarajar commented 4 years ago

Do we have a fix for the render_vector_source.cpp anywhere then?

krop commented 4 years ago

Do we have a fix for the render_vector_source.cpp anywhere then?

https://github.com/mapbox/mapbox-gl-native/commit/d7e368c4 ?