search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.36k stars 1.33k forks source link

?sku parameter added to all requests on macOS #16455

Closed 1ec5 closed 4 years ago

1ec5 commented 4 years ago

16449 removed some conditional compilation from mbgl::resourceURL() in http_file_source.mm that prevented the macOS map SDK from adding sku and offline parameters to requests. Since MapboxAccounts.framework is unavailable for macOS, ?sku is added to all requests, which doesn’t cause the request to fail but is still misleading.

The additional parameter is causing macOS unit test failures in the mapbox-gl-native-ios repository, which for better or worse is where http_file_source.mm is being unit tested.

/cc @mapbox/maps-ios