search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.35k stars 1.33k forks source link

[android, build] Switch to LLD linker. #16484

Closed tarigo closed 4 years ago

tarigo commented 4 years ago

Switching from gold linker to lld to improve binary size and linking time. Requires NDK 20+.

tarigo commented 4 years ago

Could you add some data points to this PR?

Not to this PR, but it's relevant: https://github.com/mapbox/mapbox-gl-native-android/pull/401#issuecomment-634673903

tarigo commented 4 years ago

Could you add some data points to this PR?

diff --git a/metrics/binary-size/android-arm64-v8a/metrics.json b/metrics/binary-size/android-arm64-v8a/metrics.json

index 61b7bd537..06e5ef0f2 100644

--- a/metrics/binary-size/android-arm64-v8a/metrics.json

+++ b/metrics/binary-size/android-arm64-v8a/metrics.json

@@ -3,7 +3,7 @@

         [

             "android-arm64-v8a",

             "/tmp/attach/install/android-arm64-v8a-release/lib/libmbgl-render-test-runner.so",

-            1878341

+            1853176

         ]

     ]

 }

\ No newline at end of file

diff --git a/metrics/binary-size/android-x86_64/metrics.json b/metrics/binary-size/android-x86_64/metrics.json

index 28506c0c2..d56650daa 100644

--- a/metrics/binary-size/android-x86_64/metrics.json

+++ b/metrics/binary-size/android-x86_64/metrics.json

@@ -3,7 +3,7 @@

         [

             "android-x86_64",

             "/tmp/attach/install/android-x86_64-release/lib/libmbgl-render-test-runner.so",

-            1914027

+            1885877

         ]

     ]

 }
stale[bot] commented 4 years ago

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.