search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.35k stars 1.33k forks source link

Port mapbox-gl-js PR 9372 ("Fix addImage API option for pixel ratio ") #16551

Closed JannikGM closed 3 years ago

JannikGM commented 3 years ago

In https://github.com/mapbox/mapbox-gl-js/pull/9372 the type of u_scale in fill_program was changed from vec4 to vec3. New attributes and some logic were also added.

Because mapbox-gl-native re-uses the mapbox-gl-js shaders, I feel this should have been updated or reported as issue when the submodule was updated in https://github.com/mapbox/mapbox-gl-native/pull/16298.

When I'm touching the shaders in a fork of mapbox, this discrepancy will cause errors.

Because this PR is still incomplete, I'll mark this PR as a draft, so it's mostly a reminder that this still has to be fixed. I assume the final version of the PR will also have to run scripts/generate-shaders.js, while also adding the new attributes.

Early feedback or comments welcome.

(It would be nice if you can tag this PR for hacktoberfest inclusion as described in https://hacktoberfest.digitalocean.com/details#rules - feel free to ignore this last bit if you don't want this)

stale[bot] commented 3 years ago

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.