search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.37k stars 1.33k forks source link

[Qt] Fix for style conversion with Qt 5.15 #16562

Closed j-mar closed 3 years ago

j-mar commented 3 years ago

When building with Qt 5.15, a number of features stopped rendering like icons and text. While debugging, I noticed that QVariant has started interpreting some integers as long long instead of int. This adds long long to the list of accepted QVariant types when converting toNumber() or toDouble().

Example errors when trying to add layers:

W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be a number
W0824 15:38:10.241241  :0] Unable to add layer: value must be an array of numbers
W0824 15:38:10.242242  :0] Unable to add layer: value must be a number
W0824 15:38:10.242242  :0] Unable to add layer: value must be a number
W0824 15:38:10.242242  mapbox_layer_abstract.cxx:455] Could not enable layer  "admin-1-boundary-bg"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.242242  mapbox_layer_abstract.cxx:455] Could not enable layer  "admin-0-boundary-bg"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.242242  mapbox_layer_abstract.cxx:455] Could not enable layer  "admin-0-boundary-disputed"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.242242  :0] Unable to add layer: value must be a number
W0824 15:38:10.242242  :0] Unable to add layer: value must be a number
W0824 15:38:10.242242  :0] Unable to add layer: value must be a number
W0824 15:38:10.242242  :0] Unable to add layer: value must be a number
W0824 15:38:10.242242  :0] Unable to add layer: value must be a number
W0824 15:38:10.243243  :0] Unable to add layer: value must be a number
W0824 15:38:10.243243  :0] Unable to add layer: value must be a number
W0824 15:38:10.243243  mapbox_layer_abstract.cxx:455] Could not enable layer  "waterway-label"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.243243  mapbox_layer_abstract.cxx:455] Could not enable layer  "settlement-subdivision-label"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.243243  mapbox_layer_abstract.cxx:455] Could not enable layer  "settlement-label"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.243243  mapbox_layer_abstract.cxx:455] Could not enable layer  "natural-point-label"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.243243  mapbox_layer_abstract.cxx:455] Could not enable layer  "state-label"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.243243  mapbox_layer_abstract.cxx:455] Could not enable layer  "country-label"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.243243  mapbox_layer_abstract.cxx:455] Could not enable layer  "poi-label"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.243243  :0] Unable to add layer: value must be a number
W0824 15:38:10.244244  :0] Unable to add layer: value must be a number
W0824 15:38:10.244244  :0] Unable to add layer: value must be a number
W0824 15:38:10.244244  :0] Unable to add layer: value must be a number
W0824 15:38:10.244244  mapbox_layer_abstract.cxx:455] Could not enable layer  "land-structure-polygon"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.244244  mapbox_layer_abstract.cxx:455] Could not enable layer  "land-structure-line"  because it doesn't exist in the MapboxGL widget.
W0824 15:38:10.245245  :0] Unable to add layer: value must be a number
W0824 15:38:10.245245  :0] Unable to add layer: value must be a number
W0824 15:38:10.245245  :0] Unable to add layer: value must be a number
W0824 15:38:10.245245  :0] Unable to add layer: value must be a number
W0824 15:38:10.246246  :0] Unable to add layer: value must be a number
W0824 15:38:10.246246  :0] Unable to add layer: value must be a number
W0824 15:38:10.246246  :0] Unable to add layer: value must be a number
W0824 15:38:10.246246  :0] Unable to add layer: value must be a number
W0824 15:38:10.246246  :0] Unable to add layer: value must be a number
W0824 15:38:10.246246  :0] Unable to add layer: value must be a number
stale[bot] commented 3 years ago

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.