mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.37k stars 1.33k forks source link

Blinking text sporadically around high-density at mid-zoom #5946

Closed amyleew closed 7 years ago

amyleew commented 8 years ago

Platform: iOS Mapbox SDK version: master previously b0cb8715ed74678b4d0f05829fa71a590e41b2f6

Steps to trigger behavior

  1. Low to mid zoom into high-density city like New Taipei City
  2. Pan to either side on map
  3. Zoom in and out a bit more

    Expected behavior

Normal seamless zoom around the map.

Actual behavior

Blinking place and street labels, however I only saw this happen a few time on the first load. Now I can't reproduce enough to record gif.

image

/cc @1ec5 @lucaswoj @brunoabinader

1ec5 commented 8 years ago

Clarified in chat that @amyleew and I both saw this issue in macosapp.

brunoabinader commented 8 years ago

I've experienced this a few times too - but it looks to me that it happens when we rapidly animate below and above integer zoom levels that triggers label opacity transitions as specified on the style. @amyleew @1ec5 is that what you both experienced too?

amyleew commented 8 years ago

@brunoabinader - this definitely happened only during zoom, but it only happened a few times.

brunoabinader commented 7 years ago

this definitely happened only during zoom

Zooming triggers a new placement calculation (for detecting colliding labels). Placement updates are asynchronous and prone to inconsistencies due to floating precision issues, which is the reason I believe it causes the intermittent labels to occur.

Related: #3841

jfirebaugh commented 7 years ago

⇢ #7026