search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.38k stars 1.32k forks source link

Aliased text #7599

Closed jfirebaugh closed 7 years ago

jfirebaugh commented 7 years ago

iOS, master @ 4d6c5b2d3b982c7836ea3bf32d5ee8d0c4c699f8:

image

jfirebaugh commented 7 years ago

This bisects to 38b5cb0c7766152f7e49cce8bd6c5d3e04dd0663.

cc @ansis

jfirebaugh commented 7 years ago

I haven't been able to reproduce this in macosapp or the simulator. Only seems to happen on a device.

anandthakker commented 7 years ago

Regressed due to https://github.com/mapbox/mapbox-gl-native/commit/f901e776b3e63aaaa6bc0cc4476624bf84127fe6 h/t @ericrwolfe

boundsj commented 7 years ago

Closing as re-fixed in https://github.com/mapbox/mapbox-gl-native/pull/8423 that was merged into the release-ios-v3.5.0-android-v5.0.0 release branch.

anandthakker commented 7 years ago

@boundsj should I open a new PR cherry picking the fix into master? Or do we already have a more general process for syncing the release branch back to master?

On Wed, Mar 15, 2017 at 4:05 PM Jesse Bounds notifications@github.com wrote:

Closed #7599 https://github.com/mapbox/mapbox-gl-native/issues/7599.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mapbox/mapbox-gl-native/issues/7599#event-1001593665, or mute the thread https://github.com/notifications/unsubscribe-auth/AEvmRx66mbWuUGsTzWcJW0ezxhaNCornks5rmERrgaJpZM4LbL7l .

1ec5 commented 7 years ago

We’ll merge the release branch back into master after either SDK is released. There are other changes that only went into the release branch that we’ll want to keep around. If you need the changes sooner, we can do an extra merge ahead of the releases.