search

mapbox / mapbox-gl-native

Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL
https://mapbox.com/mobile
Other
4.37k stars 1.33k forks source link

Exception zooming in using keyboard #7623

Closed 1ec5 closed 7 years ago

1ec5 commented 7 years ago

In macosapp, pressing ⌘+ to zoom in triggers the following exception:

2017-01-07 14:32:28.334 Mapbox GL[28803:1996808] -[MGLMapView validateMenuItem:]: unrecognized selector sent to instance 0x101d0e2a0
2017-01-07 14:32:28.334 Mapbox GL[28803:1996808] -[MGLMapView validateMenuItem:]: unrecognized selector sent to instance 0x101d0e2a0
2017-01-07 14:32:28.347 Mapbox GL[28803:1996808] (
    0   CoreFoundation                      0x00007fff8b1c4452 __exceptionPreprocess + 178
    1   libobjc.A.dylib                     0x00007fff8f222f7e objc_exception_throw + 48
    2   CoreFoundation                      0x00007fff8b22e10d -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
    3   Foundation                          0x00007fff8c7801db NSKVOForwardInvocation + 363
    4   CoreFoundation                      0x00007fff8b1342e2 ___forwarding___ + 514
    5   CoreFoundation                      0x00007fff8b134058 _CF_forwarding_prep_0 + 120
    6   Mapbox                              0x000000010007a334 -[MGLMapView validateMenuItem:] + 164
    7   AppKit                              0x00007fff9a5eebec -[NSMenu _enableItem:] + 706
    8   AppKit                              0x00007fff9a5ee8cb -[NSMenu _enableItems] + 222
    9   AppKit                              0x00007fff9a6b87be -[NSMenu performKeyEquivalent:] + 382
    10  AppKit                              0x00007fff9a6b88a4 -[NSMenu performKeyEquivalent:] + 612
    11  AppKit                              0x00007fff9a6b7949 -[NSApplication _handleKeyEquivalent:] + 920
    12  AppKit                              0x00007fff9a6db25b -[NSApplication _handleSpecialAlternateKeyEquivalent:] + 648
    13  AppKit                              0x00007fff9a5de120 -[NSApplication sendEvent:] + 4308
    14  AppKit                              0x00007fff9a444df2 -[NSApplication run] + 796
    15  AppKit                              0x00007fff9a40e368 NSApplicationMain + 1176
    16  Mapbox GL                           0x0000000100011152 main + 34
    17  libdyld.dylib                       0x00007fff940f35ad start + 1
    18  ???                                 0x0000000000000003 0x0 + 3
)

This issue does not reproduce with ⌘− or other keyboard shortcuts. This regression was introduced in #5999.

1ec5 commented 7 years ago

Fixed in #7624 on the release-ios-v3.4.0 branch.