search

mapbox / mapbox-gl-rtl-text

Add right-to-left text support to Mapbox GL JS
Other
53 stars 20 forks source link

Bad mapbox-gl dependency version documentation #27

Closed Danysan1 closed 4 months ago

Danysan1 commented 2 years ago

README.md says that this package "Requires mapbox-gl-js (version 0.32.1 and up).".

package.json however has a dependency to mapbox-gl >=0.32.1 <2.0.0:

  "peerDependencies": {
    "mapbox-gl": ">=0.32.1 <2.0.0"
  },

Since the latest version of mapbox-gl is 2.5.1, this dependency breaks a standard installation and should be documented in the README .

Of course it would be even better if any incompatibility with mapbox-gl >= 2.0.0 was solved and this dependency was changed. If it can be of any help some days ago I installed mapbox-gl-rtl-text 0.2.3 together with mapbox-gl 2.5.1 using --force in https://www.dsantini.it/etymology and as of now I haven't encountered problems.

fxi commented 2 years ago

Hello !

Any news on this ? We use the --legacy-peer-deps workaround since a while, but it does not feel right on the long run.

Thanks !

sven-meyer-wetter-com commented 1 year ago

Any news on that?