search

mapbox / mapbox-gl-style-spec

76 stars 38 forks source link

Make "circle-blur" units be pixels #378

Closed mcwhittemore closed 7 years ago

mcwhittemore commented 9 years ago

@anandthakker raised a question today about if it is safe for circle blur to be greater than one. The spec is a bit unclear here as it only explains what the effect of 1 should be, leaving both < 1 and > 1 to be unclear.

Optional number. Defaults to 0. Amount to blur the circle. 1 blurs the circle such that only the centerpoint is full opacity.

Looking into mapbox-gl-js circle-blur doesn't seem to be getting windowed which leads me to assume it is ok if it is greater than one. Is this right?

Either way we should update the spec to clear this kind of question up. The other blur's are in pixels, rather than an alpha channel.

mcwhittemore commented 8 years ago

@jfirebaugh any thoughts on this? Seems like < 0 shouldn't be allowed but greater than one should be. If 1 is the center point at full opacity than is 2 the center point at half opacity?

jfirebaugh commented 8 years ago

I'm not familiar with circle-blur. @tmcw or @ansis might know.

lucaswoj commented 7 years ago

This issue was moved to mapbox/mapbox-gl-js#4099