search

mapbox / mapbox-gl-style-spec

76 stars 38 forks source link

"visibility" property does not support functions #591

Closed jfirebaugh closed 7 years ago

jfirebaugh commented 7 years ago

Fixes #442.

This reflects the de-facto situation in Mapbox GL JS and Native: a visibility property value cannot be a function.

This will increase the strictness of the validator, possibly causing some existing styles to fail validation where they would previously pass. But the potential fallout in this case seems limited, since Studio has never allowed creating such a style, and it wouldn't work as anticipated in our SDKs anyway.

cc @lucaswoj @mapbox/appbox

scothis commented 7 years ago

We've been burned by adding validation in the past without also migrating styles, but this is one that seems safe.