search

mapbox / mapbox-gl-styles

Prebuilt Mapbox GL styles for use in Mapbox GL JS or the Mapbox Mobile SDKs and as a starting point for custom maps built with Mapbox Studio
Other
279 stars 144 forks source link

Add a reference table of standard icons #318

Closed lucaswoj closed 8 years ago

lucaswoj commented 8 years ago

fixes #241

A common user request is a quick reference guide of the standard icons in Mapbox styles. I think this'll be a big help to our users and a minimal maintenance burden to us.

(Apologies for the HTML rat's nest. I wanted to avoid having a header on my table which requires going full HTML)

Preview the new README here: https://github.com/mapbox/mapbox-gl-styles/tree/icon-reference#standard-icons

samanpwbb commented 8 years ago

This is great! Is there any way we can automate generating this table by using the https://github.com/mapbox/maki project? Otherwise, this will be difficult to keep up to date.

lucaswoj commented 8 years ago

It'd be possible to write a script to automatically generate this table but the script would have to be run manually every time there's a change.

Is our intention to have a 1:1 mapping between the set of Maki icons and our "standard" icons? Do you expect the set of standard icons to change in the future?

samanpwbb commented 8 years ago

It'd be possible to write a script to automatically generate this table but the script would have to be run manually every time there's a change.

Running it manually would be fine.

Is our intention to have a 1:1 mapping between the set of Maki icons and our "standard" icons? Do you expect the set of standard icons to change in the future?

The icons change with each mapbox streets source version release to match what's in the vector tile's maki field: https://www.mapbox.com/vector-tiles/mapbox-streets-v7/#poi_label. We always create maki icons for every possible field.

lucaswoj commented 8 years ago

Ready to 🚢 @samanpwbb?

samanpwbb commented 8 years ago

Looks great to me!

samanpwbb commented 8 years ago

You might want to add a little caveat somewhere:

The following icons are used in the POI layer in the Mapbox Streets-v7 data source and will be available in all Mapbox default and template styles. Styles may have additional icons in their sprites beyond those in this table.

nickidlugash commented 8 years ago

The following icons are used in the POI layer in the Mapbox Streets-v7 data source

Caveat to the caveat: These layers also use maki icons:

lucaswoj commented 8 years ago

Let's keep it simple. Users don't need those implementation details to use our standard icons. We can iterate on this later if there's any confusion.