Closed lucaswoj closed 8 years ago
This PR simplifies the text-visiblity and symbol-visibility tests, removing parameters that are unrelated to the functionality under test.
text-visiblity
symbol-visibility
The simplification also seems to fix the intermittent segfaults as well. I was not able to pin down the exact cause of the segfault.
Test CI run here: https://circleci.com/gh/mapbox/mapbox-gl-js/3839
* passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html * passed text-visibility none * passed text-visibility visible 2 passed (100.0%) Results at: /home/ubuntu/mapbox-gl-js/node_modules/mapbox-gl-test-suite/render-tests/index.html
cc @jfirebaugh @mourner @mollymerp @stackgl
This PR simplifies the
text-visiblityandsymbol-visibilitytests, removing parameters that are unrelated to the functionality under test.The simplification also seems to fix the intermittent segfaults as well. I was not able to pin down the exact cause of the segfault.
Test CI run here: https://circleci.com/gh/mapbox/mapbox-gl-js/3839
cc @jfirebaugh @mourner @mollymerp @stackgl