search

mapbox / mapbox-gl-test-suite

Rendering tests for Mapbox GL
6 stars 12 forks source link

Updated tests for bidirectional line breaking #186

Closed ChrisLoer closed 7 years ago

jfirebaugh commented 7 years ago

Is there a minimal change we could make in gl-js to bring it back into alignment (heh) on the text-anchor/text-justify tests, short of the full fix for https://github.com/mapbox/mapbox-gl-js/issues/3707? It'd be nice not to have to ignore those tests.

ChrisLoer commented 7 years ago

Probably -- I'll look into a minimal gl-js change.

ChrisLoer commented 7 years ago

After looking at it a little, I think it's best to wait until I bring a larger set of changes over. Before the refactoring, there's a lot of fiddling with indices necessary to try to do something like a trim operation. What I can do is implement the "apply line breaking before doing layout" refactoring on gl-js without pulling in the ICU dependency.