search

mapbox / mapbox-maps-android

Interactive, thoroughly customizable maps in native Android powered by vector tiles and OpenGL.
https://www.mapbox.com/mobile-maps-sdk
Other
478 stars 134 forks source link

rememberGeoJsonSourceState causes transaction too large exception when saving state #2465

Open jacobtabak opened 3 months ago

jacobtabak commented 3 months ago

Environment

Observed behavior and steps to reproduce

We are loading some pretty complex geometry (testing with 1175 features) and following the examples, I tried using rememberGeoJsonSourceState in compose. However, under the hood, this function uses rememberSaveable which tries to persist all of those features to a bundle to save their state when the activity is paused. This of course causes a crash for our use case which was a bit tricky to debug because it was not immediately clear why the bundle was so large until we dug into the code.

Would it be reasonable to suggest making separate functions for rememberGeoJsonSourceState and rememberGeoJsonSourceStateSaveable? For our use case we just implemented a non-saveable version.

Expected behavior

Don't crash when saving state

Notes / preliminary analysis

Additional links and references

                                         java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 687388 bytes
                                            at android.app.ActivityClient.activityStopped(ActivityClient.java:87)
                                            at android.app.servertransaction.PendingTransactionActions$StopInfo.run(PendingTransactionActions.java:143)
                                            at android.os.Handler.handleCallback(Handler.java:938)
                                            at android.os.Handler.dispatchMessage(Handler.java:99)
                                            at android.os.Looper.loopOnce(Looper.java:201)
                                            at android.os.Looper.loop(Looper.java:288)
                                            at android.app.ActivityThread.main(ActivityThread.java:7870)
                                            at java.lang.reflect.Method.invoke(Native Method)
                                            at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
                                         Caused by: android.os.TransactionTooLargeException: data parcel size 687388 bytes
                                            at android.os.BinderProxy.transactNative(Native Method)
                                            at android.os.BinderProxy.transact(BinderProxy.java:571)
                                            at android.app.IActivityClientController$Stub$Proxy.activityStopped(IActivityClientController.java:1315)
                                            at android.app.ActivityClient.activityStopped(ActivityClient.java:84)
                                            at android.app.servertransaction.PendingTransactionActions$StopInfo.run(PendingTransactionActions.java:143) 
                                            at android.os.Handler.handleCallback(Handler.java:938) 
                                            at android.os.Handler.dispatchMessage(Handler.java:99) 
                                            at android.os.Looper.loopOnce(Looper.java:201) 
                                            at android.os.Looper.loop(Looper.java:288) 
                                            at android.app.ActivityThread.main(ActivityThread.java:7870) 
                                            at java.lang.reflect.Method.invoke(Native Method) 
                                            at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 
                                            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) 
kiryldz commented 2 months ago

@jacobtabak although this is a valid issue and we'll try to think what could be improved here, please keep in mind that we [recommend](https://docs.mapbox.com/android/maps/api/11.6.0/mapbox-maps-android/com.mapbox.maps.extension.compose.style.sources.generated/remember-geo-json-source-state.html?query=inline%20fun%20rememberGeoJsonSourceState(key:%20String?%20=%20null,%20sourceId:%20String%20=%20remember%20{%20%20%20%20generateRandomSourceId(%22geojson%22)%20%20},%20crossinline%20init:%20GeoJsonSourceState.()%20-%3E%20Unit%20=%20{}):%20GeoJsonSourceState) using your own remember when working with large amounts of data. Can you try this out?