mapbox / mapbox-maps-flutter

Interactive, thoroughly customizable maps for Flutter powered by Mapbox Maps SDK
https://www.mapbox.com/mobile-maps-sdk
Other
286 stars 117 forks source link

Web support #13

Open skreborn opened 1 year ago

skreborn commented 1 year ago

The README states that "Web and desktop are not supported" - I'm wondering if that's a limitation as of this moment, or something that you don't intend to support even if the implementation is done by someone?

yunikkk commented 1 year ago

@skreborn hi, there is indeed no plan for Web/Desktop at the moment. We haven't considered supporting 3party implementation yet, however contributions are welcome and it could probably indeed happen when the repo is established and ready for it (part of the tooling for codegen etc is still private).

skreborn commented 1 year ago

Thank you for your response - I understand. I imagine the first step would be relying on a plugin interface and separate implementation packages instead of putting everything into a single package. I'll keep an eye on the project.

cedvdb commented 1 year ago

Wasn't there plans on the mapbox part to have one underlying code base for all platforms ? IE: wasm ?

marianhlavac commented 1 year ago

Having official Flutter plugin for Mapbox with web support would be great.

it could probably indeed happen when the repo is established and ready for it (part of the tooling for codegen etc is still private)

@yunikkk Is there any way community can help?

srmncnk commented 1 year ago

@marianhlavac @yunikkk @skreborn Community already did: https://github.com/flutter-mapbox-gl/maps

This is a fork of the original project from Mapbox. Community did web support, it works well. And this repo resembles the original structure very much - but it differs in one key aspect - the class implementations are all private, thus even if community wanted to port the existing web implementation, it can't.

I am sure the community (myself very much included) would be eager to prepare PRs for web, but Mapbox needs to enable us in doing so.

lukas-h commented 1 year ago

any news here?

aardrop commented 10 months ago

Six months since any activity here, we would love an update as we're happy to contribute to this feature but can't move from the tobrun's open source package to this one until the web is supported.

HHLiftBridge commented 9 months ago

I am also interested in web support for this plugin. Has the stance on web changed?

LinschotenMelle commented 9 months ago

Our project is unfortunately not compatable with the package mapbox_gl so were also very also interested in web support for this plugin.

tfvtti commented 8 months ago

We would like to move from mapbox_gl but our application has a web future so please add support for web.

felix-ht commented 8 months ago

@evil159 any updates on this? Are you willing to support the community with reviewing PRs and get them merged? I don't want to do any work for this repo to just have the PR rejected/ignored

Fakerinc commented 7 months ago

I would love this as well!

aardrop commented 6 months ago

@evil159 any updates on this? Are you willing to support the community with reviewing PRs and get them merged? I don't want to do any work for this repo to just have the PR rejected/ignored

Exactly, I would also love to support this if it means we can incorporate it into this package.

srmncnk commented 6 months ago

In the meantime ESRI did this: https://pub.dev/packages/arcgis_map_sdk They claim they support web, I haven't checked it out yet though.

srmncnk commented 6 months ago

Not to mention https://pub.dev/packages/maplibre_gl.

JEThilenius commented 2 months ago

We would like to move from mapbox_gl but our application has a web future so please add support for web.

We are very interested in doing the same!

aardrop commented 4 weeks ago

Six-month check-in here: I'd love to contribute to getting the web plugged in here, but with @evil159 providing so much support, I don't want to build something that is out of schema or won't be merged.

It's likely that the third-party open-source version won't support upcoming Flutter updates, and we can't move to this version unless it supports the web.

evil159 commented 4 weeks ago

Hello everyone,

Apologies for the delayed response, and thank you so much for your offer to help implement web support for our Flutter SDK. We really appreciate your enthusiasm and willingness to contribute!

To clarify, we’re open to accepting contributions for web support, but we want to set the right expectations regarding maintenance. While we can introduce web support as an experimental feature, we’re not in a position to guarantee the same level of maintenance and long-term support that we provide for other platforms—at least not until we see higher demand for web usage.

This means web support would remain in an experimental state for the time being, with the possibility of full support in the future if the demand grows.

Since the project originated from our mobile team at Mapbox, the public API is naturally more aligned with mobile workflows. While many concepts are shared between mobile and web, there may be cases where the APIs don’t map perfectly.

To get the conversation started and explore the possibilities, would you be open to creating a proof-of-concept (PoC) pull request? This would give us a solid foundation for discussion and help shape the direction moving forward.

srmncnk commented 4 weeks ago

@evil159 Thank you for your response.

My two cents regarding pull requests - it may have changed since I last looked, but doing pull requests is probably impossible due to two reasons:

Otherwise I imagine we would be thrilled to have web even as an experimental feature. As long as we can contribute to it. It has been this way since the beginning of the flutter package after all.

evil159 commented 4 weeks ago

@srmncnk To enable this we are willing to make the required accommodations in our SDK codebase, for the purposes of PoC I think it's fine to tamper with private APIs, expose private classes etc. Yeah, currently the templates are in another repo, we'll have to move them here for this to work, I don't think it's required on PoC level, it doesn't have to be all-encompassing, just a web view with a map should be good enough, if there will be a way to set style uri/json that will be awesome.

srmncnk commented 4 weeks ago

@evil159 So you're saying you're willing to accept PRs that will modify private class names as well? I think we'd still appreciate access to the template though.