mapbox / mapbox-maps-flutter

Interactive, thoroughly customizable maps for Flutter powered by Mapbox Maps SDK
https://www.mapbox.com/mobile-maps-sdk
Other
252 stars 94 forks source link

ktlint issue on library usage #22

Closed praveentcom closed 1 year ago

praveentcom commented 1 year ago

flutter run gives an error related to referencing ktlint.gradle.

* Where:
Build file '/Users/praveen/development/flutter/.pub-cache/hosted/pub.dartlang.org/mapbox_maps_flutter-0.3.0/android/build.gradle' line: 57

* What went wrong:
A problem occurred evaluating project ':mapbox_maps_flutter'.
> Could not read script '/Users/praveen/***/android/gradle/ktlint.gradle' as it does not exist.

Upon checking the library, it's referencing these two files on the root directory.

project.apply {
    from("$rootDir/gradle/ktlint.gradle")
    from("$rootDir/gradle/lint.gradle")
}

The end user need not have these files.

dawid-niedzwiecki commented 1 year ago

Same problem here

praveentcom commented 1 year ago

Temporarily unblocked by copy-pasting the two files to my project directory.

Expecting the library to be patched.

yunikkk commented 1 year ago

This is already patched in main and will be fixed in the next minor release.

sunderee commented 1 year ago

Confirmed, if you add mapbox_maps_flutter as a Git dependency, and use ref: main, the issue is resolved. Thank you!

geisterfurz007 commented 1 year ago

For those not looking to copy things around or moving to main as ref, you can just create ktlint.gradle and lint.gradle as empty files.

yunikkk commented 1 year ago

Should be fixed with 0.4.0.