search

mapbox / mapbox-navigation-android

Mapbox Navigation SDK for Android
https://docs.mapbox.com/android/navigation/overview/
Other
622 stars 319 forks source link

Request: Provide clearing methods for MapboxMap.Style components (Image, Source...) #3572

Open carstenhag opened 4 years ago

carstenhag commented 4 years ago

Android API: 10 Mapbox Navigation SDK version:

    implementation 'com.mapbox.navigation:ui:1.0.0-rc.7'
    implementation 'com.mapbox.navigation:core:1.0.0-rc.7'

Why would we like to have this feature?

  1. Setup a mapboxMap, a navigation, a navigationMapRoute etc.
  2. Add a custom image, source and layer in order to add a marker (Apparently we use this way of adding markers, we don't use the annotation plugin, no idea why)
  3. Get re-routed due to a mapbox or an external event
  4. Want to clear previous images, sources, layers, etc easily without keeping track of them ourselves.

Expected behavior

Either a method like removeImage() without a parameter or a removeImages() or clearImages method.

Actual behavior

There are only removeImage(name: String), removeSource(...), removeLayer(...) methods, which take individual objects.

Guardiola31337 commented 4 years ago

cc @abhishek1508 @JunDai

Guardiola31337 commented 3 years ago

cc'ing @cafesilencio for visibility

Guardiola31337 commented 3 years ago

Where are we here? Any updates? @cafesilencio @abhishek1508

abhishek1508 commented 3 years ago

@Guardiola31337 This seems more like something that should be addressed by Maps SDK

Guardiola31337 commented 3 years ago

This seems more like something that should be addressed by Maps SDK

cc @tobrun @LukasPaczos

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.