search

mapbox / mapbox-navigation-android

Mapbox Navigation SDK for Android
https://docs.mapbox.com/android/navigation/overview/
Other
622 stars 319 forks source link

Revamp the turn icons used in Mapbox Android Nav SDK #5382

Closed abhishek1508 closed 2 years ago

abhishek1508 commented 2 years ago

Mapbox Android Navigation SDK uses a default set of turn icons in the form of vector drawables. These vector drawables are used when showing maneuver turn instructions. However, some of these vector drawables are confusing and need to be revamped. There are customer issues being reported as well in regards to incorrect icons. Issues with icons have been brought up verbally very often and we should take this up on a priority to fix them.

Vector drawables used are attached. turnicons.zip

Unfortunately I don't have the .svg files for these drawables.

/cc @mapbox/navigation-android @lawsonkight

1ec5 commented 2 years ago

Are you referring to the main maneuver icon? Can you use the assets in https://github.com/mapbox/navigation-ui-resources/tree/1ec5-vector-drawables/img/maneuvers/ for consistency with iOS?

abhishek1508 commented 2 years ago

Are you referring to the main maneuver icon?

Yes.

Can you use the assets in https://github.com/mapbox/navigation-ui-resources/tree/1ec5-vector-drawables/img/maneuvers/ for consistency with iOS?

I can probably use some of them. Some icons like fork: slight right, fork: right, merge: slight right, uturn, depart right and few more are not available in the link you shared. Since these icons are already public we cannot remove their support or else we would be introducing regression.

1ec5 commented 2 years ago

There’s no such thing as a slight right fork or slight right merge, so just replace them with the non-slight versions if you need to maintain backwards compatibility, but I would recommend deprecating them so that developers don’t expect them to occur in practice.

We don’t have an asset for a departure instruction. The iOS navigation SDK has always shown the first instruction instead. But if necessary, I can whip one up by repositioning the 📍 on the arrival icons.

The fork icon is to the right. Do you need me to export a vector drawable that flips it to the left, or can you do that on the fly? There’s no such thing as going straight at a fork; otherwise, it wouldn’t be a fork. If you encounter that, pick a side based on the driving side.

The U-turn icon is called “arrow 180 right” for consistency with the other angle-based arrows. Feel free to rename it.

tomaszrybakiewicz commented 2 years ago

Hey @1ec5. Does iOS use different depart icons?

new_2

Any chance you could export and add them to navigation-ui-resources folder?