search

mapbox / mapbox-navigation-android

Mapbox Navigation SDK for Android
https://docs.mapbox.com/android/navigation/overview/
Other
622 stars 319 forks source link

[Android Auto] Remove SearchEngine from `MainCarContext` constructor #6154

Closed kmadsen closed 2 years ago

kmadsen commented 2 years ago

The search api is subject to change and it cannot be in the android auto api. Remove it and resolve the issues as internal implementations.

https://github.com/mapbox/mapbox-navigation-android/blob/bf0f61f96c3942b28daea4aa010238380b20acb3/qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/car/MainCarSession.kt#L71-L77

kmadsen commented 2 years ago

cc: @Zayankovsky

kmadsen commented 2 years ago

Referencing a larger issue https://github.com/mapbox/mapbox-navigation-android/issues/5786

I think these issues should be solved separately but they are related.

kmadsen commented 2 years ago

It should also not be required to integrate the CarSearchLocationProvider in order to make android auto work.

https://github.com/mapbox/mapbox-navigation-android/blob/bf0f61f96c3942b28daea4aa010238380b20acb3/qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/car/search/CarSearchLocationProvider.kt#L18-L20