search

mapbox / mapbox-navigation-android

Mapbox Navigation SDK for Android
https://docs.mapbox.com/android/navigation/overview/
Other
621 stars 318 forks source link

Request: Provide precompiled version with ndk >= 23 #7565

Open santitopo opened 11 months ago

santitopo commented 11 months ago

Hello! I'm opening this issue after this previous discussion in the Expo repository.

Long story short, I'm trying to create an Expo module in order to use Mapbox Navigation in an Expo-managed React Native app (by wrapping Android and iOS native sdks). In iOS I got it working, but in Android I'm experiencing a crash on runtime, when attempting to render the most minimal example of your drop-in UI (a very basic NavigationView).

I tried reproducing the error in a clean Android project and it obviously doesn't happen (here's a repo with the minimal code working), so that led me to think the issue was related to some incompatibility between Expo/React Native and the Android Mapbox Nav sdk.

@kudo checked out the issue and suggested that the incompatibility could have to do with the fact that this library is prebuilt with ndk r21, which is incompatible with ndk r23 in React Native 0.72 / expo sdk 49.

relevant code https://github.com/mapbox/mapbox-navigation-android/blob/3d7f04aedec72f063d28731cd9facd70114b5cf3/gradle/dependencies.gradle#L181 that AGP 7.2.2 is still using ndk r21 by default.

My request then (and I'm probably speaking for the whole React Native/Expo community here 😅) is if it could be possible to provide a precompiled version with a higher ndk, or provide some other solution.

Thanks a lot in advance and hope that we can come to a solution together! I've seen plenty of devs out there wanting to use this sdk through the years 🙌 (https://github.com/mapbox/mapbox-navigation-android/issues/1312, https://github.com/homeeondemand/react-native-mapbox-navigation/issues/112, https://github.com/mapbox/mapbox-navigation-android/issues/1652, https://github.com/mapbox/mapbox-navigation-android/issues/2441, https://github.com/homeeondemand/react-native-mapbox-navigation, and more 😄 )

Android API: Any Mapbox Navigation SDK version: 2.16

santitopo commented 11 months ago

Probably related with https://github.com/mapbox/mapbox-maps-android/issues/1697 👀

santitopo commented 10 months ago

Definitely related with https://github.com/mapbox/mapbox-navigation-android/issues/6929

doiska commented 7 months ago

Any update on this? It's been a deal breaker for me. Thank you guys!

j-fro commented 7 months ago

This is a major blocker for us too - hoping for an update here. Thanks!

ismael-su commented 7 months ago

2 of our clients had to drop react native expo because of this problem, please mapbox, do something. Is there any way to reach someone on the core dev team at mapbox ?

jmysliv commented 6 months ago

We are having the same issue.

@LukasPaczos do you plan to bump NDK to 23 in the near future?

LukasPaczos commented 6 months ago

Hey everyone! The Navigation SDK Core Framework, which is an evolution of the Navigation SDK v2 and currently in a public preview pre-release, is built with NDK 23 and should hopefully resolve the issues you're running into.

The pre-release version of the Navigation SDK Core Framework does not come with the Drop-In UI but the base, non-UI capabilities are available so you could give it a try while we're ramping up towards a stable release. Check out a migration guide here.

santitopo commented 6 months ago

Hey everyone! The Navigation SDK Core Framework, which is an evolution of the Navigation SDK v2 and currently in a public preview pre-release, is built with NDK 23 and should hopefully resolve the issues you're running into.

The pre-release version of the Navigation SDK Core Framework does not come with the Drop-In UI but the base, non-UI capabilities are available so you could give it a try while we're ramping up towards a stable release. Check out a migration guide here.

Hey! Great news ! Thanks for letting us know. Is there a plan to also release the drop in ui compiled with NDK 23 at some point? Or are you dropping support for it?

boudewijnv commented 5 months ago

Looks like there is a public preview available for Mapbox Navigation SDK UX Framework as well.

The pre-release version of the Navigation SDK Core Framework does not come with the Drop-In UI but the base, non-UI capabilities are available so you could give it a try while we're ramping up towards a stable release. Check out a migration guide here.

@LukasPaczos that is good news. Do you have any clue about the timeline? Do you expect a stable release in weeks, months or longer?