search

mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
861 stars 310 forks source link

MapboxNavigation podspec fails validation #172

Closed 1ec5 closed 5 years ago

1ec5 commented 7 years ago

MapboxNavigation.podspec fails CocoaPods validation due to some warnings. (I have to pass --allow-warnings every time I push the podspec to trunk.) Some of these warnings are upstream in AWSCore and Pulley. The warnings in MGLMapView+MGLNavigationAdditions.h are caused by the hack in #57. Until mapbox/mapbox-gl-native#6867 is fixed, we should silence the warning using #pragma clang compiler directives.

Validating podspec
 -> MapboxNavigation (0.3.0)
    - WARN  | xcodebuild:  AWSCore/AWSCore/Fabric/Fabric.h:43:11: warning: parameter 'kits' not found in the function declaration [-Wdocumentation]
    - NOTE  | xcodebuild:  AWSCore/AWSCore/Fabric/Fabric.h:43:11: note: did you mean 'kitClasses'?
    - WARN  | xcodebuild:  Pulley/PulleyLib/PulleyViewController.swift:747:94: warning: 'FLT_EPSILON' is deprecated: Please use 'Float.ulpOfOne' or '.ulpOfOne'.
    - WARN  | xcodebuild:  Pulley/PulleyLib/PulleyViewController.swift:750:75: warning: 'FLT_EPSILON' is deprecated: Please use 'Float.ulpOfOne' or '.ulpOfOne'.
    - WARN  | xcodebuild:  AWSPolly/AWSPolly/AWSPollySynthesizeSpeechURLBuilder.h:200:9: warning: parameter 'configuration' not found in the function declaration [-Wdocumentation]
    - WARN  | xcodebuild:  AWSPolly/AWSPolly/AWSPollySynthesizeSpeechURLBuilder.h:217:9: warning: parameter 'preSignedURLRequest' not found in the function declaration [-Wdocumentation]
    - NOTE  | xcodebuild:  AWSPolly/AWSPolly/AWSPollySynthesizeSpeechURLBuilder.h:217:9: note: did you mean 'getPreSignedURLRequest'?
    - WARN  | xcodebuild:  MapboxNavigation/MapboxNavigation/MGLMapView+MGLNavigationAdditions.m:3:17: warning: method definition for 'locationManager:didUpdateLocations:' not found [-Wincomplete-implementation]
    - NOTE  | xcodebuild:  MapboxNavigation/MapboxNavigation/MGLMapView+MGLNavigationAdditions.h:6:1: note: method 'locationManager:didUpdateLocations:' declared here

[!] The spec did not pass validation, due to 6 warnings (but you can use `--allow-warnings` to ignore them).

/cc @frederoni @bsudekum

1ec5 commented 7 years ago

Let’s keep this open to track reporting and fixing the upstream warnings, since they block pushing to CocoaPods trunk without the special flag.

1ec5 commented 5 years ago

This issue is long out of date: we removed the AWS SDK and Polly dependencies in mapbox/mapbox-navigation-ios#617 and the Polly dependency in mapbox/mapbox-navigation-ios#785.