search

mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
863 stars 313 forks source link

ETA label is too small #2645

Closed 1ec5 closed 4 years ago

1ec5 commented 4 years ago

The ETA label is the same size as the distance traveled label. It should be considerably larger as seen in #2569.

b30c71533e884bd807367690a06fbc569b5b5168 7866e550a9b363d2fe438669c2da2429361a4ce4
big small

This regression was introduced toward the end of the v1.0 release cycle.

/cc @mapbox/navigation-ios

avi-c commented 4 years ago

Looks like the UIAppearance font property is not being applied properly. Indeed, even the small size seen now for the distance travelled label is incorrect at 16pts and not the 18pts it was before. 16 points is what's inherited from the base StylableLabel class, not the 18 intended for theDistanceRemainingLabel subclass.

Not sure why this changed partway through the release though.