search

mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
860 stars 310 forks source link

Casing is incorrectly drawn for vanishing route line with intermediate waypoint. #2733

Open MaximAlien opened 3 years ago

MaximAlien commented 3 years ago

Mapbox Navigation SDK version: main

After reverting back NavigationMapView.shape(forCasingOf:legIndex:) in https://github.com/mapbox/mapbox-navigation-ios/pull/2623 main route casing for vanishing route line is no longer in sync during active-guidance navigation. For example:

Screen Shot 2020-11-09 at 12 31 29 PM

@Udumft, @1ec5 I think you mentioned that there are clients that still use this method. Would you be able to describe it in more detail? When I look at current implementation of NavigationMapView.shape(forCasingOf:legIndex:) here: https://github.com/mapbox/mapbox-navigation-ios/blob/829a91c87ebdce876dd0f906467ebaa8693ca14c/MapboxNavigation/NavigationMapView.swift#L1206-L1221

it seems that its implementation should be similar to NavigationMapView.shape(for:legIndex:).

/cc @mapbox/navigation-ios @1ec5 @Udumft

1ec5 commented 3 years ago

I think you mentioned that there are clients that still use this method. Would you be able to describe it in more detail?

We’ve heard about this issue from a couple developers, including in #2678, but also for another customer who’s using the route shape override.