mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
861 stars 314 forks source link

Two issues from user's point view #3279

Open DiegoResnik opened 3 years ago

DiegoResnik commented 3 years ago

I started using a demo app with navigation ios sdk 2.0 beta (I think it was 19 or 20).

I've noticed two issues:

  1. If you look at the image, you will see the top direction element is not synced with the actual driving directions...it says to turn left when the direction chose to turn right...regular navigation in open road...not a rerouting or anything.

IMG_9320

  1. I've noticed that sometimes when I stop the car (lets say in a traffic light), the map starts "dancing" back and forward, again in an open road, location services should be ok..and when I drive it stabilize again.
1ec5 commented 3 years ago

If you look at the image, you will see the top direction element is not synced with the actual driving directions...it says to turn left when the direction chose to turn right...regular navigation in open road...not a rerouting or anything.

This is unexpected. The map is showing this on-ramp, but the banner instruction is for getting onto this road, which was presumably earlier in the route. Did you see this mismatch throughout the route or only at this point? At any point, did you tap or swipe down on the top banner to reveal the list of steps, or swipe the top banner to one side to preview a subsequent step?

I've noticed that sometimes when I stop the car (lets say in a traffic light), the map starts "dancing" back and forward, again in an open road, location services should be ok..and when I drive it stabilize again.

This is a known issue that we’re continually refining. It’d be difficult to diagnose this issue without a detailed history trace, however. There’s a method on RouteController for enabling history recording.

DiegoResnik commented 3 years ago

Hi, I can't be sure for 100%, but I don't think I swiped the top banner. I've noticed this only in this location...it was very obvious it was directing me to the opposite direction of where I was heading...I will update you when I drive for the same location again with an updated version. As for the 2nd problem, I will try to find this property and set it on to get more information for you.

DiegoResnik commented 3 years ago

Here's a sample of the "dancing" map. This time, it started from the parking lot where the drive started till the end of it.

https://user-images.githubusercontent.com/19625881/136598200-51b964ee-3f9c-40ef-a241-38ca7272876c.mp4

ShanMa1991 commented 3 years ago

The dancing seems to be between the some location and the current user location. Because the user location indicator is not dancing, but the camera is dancing, which means that the camera keeps receiving the location from somewhere and then reports to the camera. It would be related with the NavigationViewportDataSourceas a LocationConsumer of the mapView when the viewportDataSourceType as .raw: https://github.com/mapbox/mapbox-navigation-ios/blob/53021fa005777052c2b5dc8ba15b3223e81051a6/Sources/MapboxNavigation/NavigationViewportDataSource.swift#L77-L80

https://github.com/mapbox/mapbox-navigation-ios/blob/53021fa005777052c2b5dc8ba15b3223e81051a6/Sources/MapboxNavigation/NavigationViewportDataSource.swift#L503-L507

ShanMa1991 commented 3 years ago

It's very similar as #3276, but the #3276 happens under simulating mode.