search

mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
861 stars 310 forks source link

PR #4525 merged without successful status checks (mapbox-navigation-ios) #4556

Closed mapbox-github-ci-issues-1[bot] closed 11 months ago

mapbox-github-ci-issues-1[bot] commented 11 months ago

:wave: Hey there! It's Changebot, and I help repositories follow our engineering best practices. My magic wand found some things I wanted to highlight for your review:

Item Current status Required? Best practice guidelines
Run unsuccessful: publisher-deployer neutral optional success
Run unsuccessful: CodeQL neutral optional success
Run unsuccessful: Analyze (swift) failure optional success

The following PR was merged without the status checks passing: https://github.com/mapbox/mapbox-navigation-ios/pull/4525

Can you take a look at these best practices and make any adjustments if needed?

Please tag @mapbox/security-and-compliance on this issue if you have any questions

Udumft commented 11 months ago

Checks were re-run and successfull after pulling changes from external fork