mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
861 stars 311 forks source link

PR #4596 merged without successful status checks (mapbox-navigation-ios) #4598

Closed mapbox-github-ci-issues-5[bot] closed 7 months ago

mapbox-github-ci-issues-5[bot] commented 7 months ago

:wave: Hey there! It's Changebot, and I help repositories follow our engineering best practices. My magic wand found some things I wanted to highlight for your review:

Item Current status Required? Best practice guidelines
Run unsuccessful: ci/circleci: Xcode_14.2.0 pod install pending required success
Run unsuccessful: ci/circleci: Xcode_15.2_iOS_17.2_SPM_Debug pending optional success
Run unsuccessful: ci/circleci: Publish Documentation pending required success
Run unsuccessful: ci/circleci: Build Example pending required success
Run unsuccessful: ci/circleci: Xcode_14.3.1 pod update pending required success
Run unsuccessful: ci/circleci: Xcode_14.3.1_iOS_16.4_Debug pending required success
Run unsuccessful: ci/circleci: Xcode_14.1.0_iOS_15.5 pending optional success
Run unsuccessful: ci/circleci: Xcode_14.1_iOS_16.1 pending required success
Run unsuccessful: ci/circleci: Xcode_14.1.0_iOS_16.1_SPM_Release pending required success
Run unsuccessful: ci/circleci: Xcode_14.1.0_iOS_16.1_Release pending required success
Run unsuccessful: ci/circleci: Core integration test; Xcode 14.1; iOS 16.1 pending optional success
Run unsuccessful: ci/circleci: Xcode_14.1_iOS_16.1_SPM_Debug pending required success
Run unsuccessful: ci/circleci: Create breaking changes PR comment pending required success
Run unsuccessful: publisher-deployer neutral optional success
Run unsuccessful: Analyze (swift) null optional success

The following PR was merged without the status checks passing: https://github.com/mapbox/mapbox-navigation-ios/pull/4596

Can you take a look at these best practices and make any adjustments if needed?

Please tag @mapbox/security-and-compliance on this issue if you have any questions