mapbox / mapbox-navigation-ios

Turn-by-turn navigation logic and UI in Swift on iOS
https://docs.mapbox.com/ios/navigation/
Other
863 stars 313 forks source link

Add support for carplay to hide waypoints from route line #4606

Closed chizhavko closed 8 months ago

chizhavko commented 8 months ago

Description

From this ticket: https://mapbox.atlassian.net/browse/NAVIOS-1619 To hide waypoints on route line. Later they override NavigationMapDelegate. For now this method not used and CarPLayManagerDelegate only support configuration of destination waypoint. In this MR i added ability to hide intermediate waypoints on the route line.

mapbox-github-ci-issues-public-1[bot] commented 8 months ago

API compatibility report for MapboxNavigation: 🔴

Protocol Requirement Change

mapbox-github-ci-issues-public-1[bot] commented 8 months ago

API compatibility report for MapboxNavigation: 🔴

Protocol Requirement Change

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 60.54%. Comparing base (c09a4b8) to head (9b58b55).

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
- Coverage   60.63%   60.54%   -0.10%     
==========================================
  Files         189      189              
  Lines       21265    21297      +32     
==========================================
  Hits        12894    12894              
- Misses       8371     8403      +32     
Files Coverage Δ
Sources/MapboxNavigation/CarPlayManager.swift 44.35% <0.00%> (-0.28%) :arrow_down:
...rces/MapboxNavigation/CarPlayManagerDelegate.swift 3.07% <0.00%> (-0.21%) :arrow_down:
...tion/CarPlayNavigationViewControllerDelegate.swift 0.00% <0.00%> (ø)
...oxNavigation/CarPlayNavigationViewController.swift 14.34% <0.00%> (-0.16%) :arrow_down: